Roger Ebert called him “our best writer on cinema.” His scholarship focused on how movies work.